Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use variable str in readme example #2

Merged

Conversation

kyleshevlin
Copy link
Contributor

@kyleshevlin kyleshevlin commented Apr 22, 2017

I thought it would be more consistent to use the variable name in the readme example rather than the string duplicated.

@kyleshevlin
Copy link
Contributor Author

@kyleshevlin kyleshevlin commented Apr 22, 2017

Fails CI because of a linting error in index.js. Your linter expects a declaration of why you're disabling eslint for line 10.

@sindresorhus sindresorhus changed the title use variable str in readme example Use variable str in readme example Apr 22, 2017
@sindresorhus sindresorhus merged commit c9032db into sindresorhus:master Apr 22, 2017
1 check failed
@kyleshevlin kyleshevlin deleted the use-variable-in-example branch Apr 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants