Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Node.js 8, add TypeScript definition #6

Merged
merged 2 commits into from Apr 17, 2019
Merged

Require Node.js 8, add TypeScript definition #6

merged 2 commits into from Apr 17, 2019

Conversation

BendingBender
Copy link
Contributor

@BendingBender BendingBender commented Apr 16, 2019

No description provided.

@sindresorhus sindresorhus merged commit 578f3a7 into sindresorhus:master Apr 17, 2019
1 check was pending
import stripIndent = require('strip-indent');
const string = '\tunicorn\n\t\tcake';
// unicorn
Copy link
Owner

@sindresorhus sindresorhus Apr 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open an issue on VS Code about supporting either /* */ comments unescaped inside codeblocks in doc comments (preferred) or alternatively/additionally support escaped \/* */ comments inside doc comments (meaning it's not displayed as escaped). It's silly that we have to use line comments like this. It makes it harder to read the example output.

Copy link
Contributor Author

@BendingBender BendingBender Apr 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened an issue.

goto-bus-stop pushed a commit to u-wave/react-server-list that referenced this issue Apr 17, 2019
## The dependency [strip-indent](https://github.com/sindresorhus/strip-indent) was updated from `2.0.0` to `3.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v3.0.0</summary>

<p>Breaking:</p>
<ul>
<li>Require Node.js 8 (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="433933703" data-permission-text="Issue title is private" data-url="sindresorhus/strip-indent#6" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/strip-indent/pull/6/hovercard" href="https://urls.greenkeeper.io/sindresorhus/strip-indent/pull/6">#6</a>)  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/strip-indent/commit/578f3a7bcc87c722594730e8d469d4412090cbda/hovercard" href="https://urls.greenkeeper.io/sindresorhus/strip-indent/commit/578f3a7bcc87c722594730e8d469d4412090cbda"><tt>578f3a7</tt></a></li>
</ul>
<p>Enhancements:</p>
<ul>
<li>Add TypeScript definition (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="433933703" data-permission-text="Issue title is private" data-url="sindresorhus/strip-indent#6" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/strip-indent/pull/6/hovercard" href="https://urls.greenkeeper.io/sindresorhus/strip-indent/pull/6">#6</a>)  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/strip-indent/commit/578f3a7bcc87c722594730e8d469d4412090cbda/hovercard" href="https://urls.greenkeeper.io/sindresorhus/strip-indent/commit/578f3a7bcc87c722594730e8d469d4412090cbda"><tt>578f3a7</tt></a></li>
</ul>
<p><a class="commit-link" href="https://urls.greenkeeper.io/sindresorhus/strip-indent/compare/v2.0.0...v3.0.0"><tt>v2.0.0...v3.0.0</tt></a></p>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 8 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/sindresorhus/strip-indent/commit/b537c94fd8376e4205146fbbef0bc08a477c5eab"><code>b537c94</code></a> <code>3.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/strip-indent/commit/575ba7dde434627a3647a36e670d69c38cbdefb6"><code>575ba7d</code></a> <code>Meta tweaks</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/strip-indent/commit/578f3a7bcc87c722594730e8d469d4412090cbda"><code>578f3a7</code></a> <code>Require Node.js 8, add TypeScript definition (#6)</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/strip-indent/commit/767c46536bb2606a89f81d8ed4d0afbf1e9839b7"><code>767c465</code></a> <code>Meta tweaks</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/strip-indent/commit/089df03598849be53568d01dc92e530adf02f051"><code>089df03</code></a> <code>Use min-indent (#4)</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/strip-indent/commit/dbeb23243094331b847d3c296a4915ff0b05f3b6"><code>dbeb232</code></a> <code>Meta tweaks</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/strip-indent/commit/c9032dbd9820257d4c217204245530c4d9e58818"><code>c9032db</code></a> <code>Use variable <code>str</code> in readme example (#2)</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/strip-indent/commit/7c2f0e09ef4751c8bf2dc05d6ecb3c6df93689a3"><code>7c2f0e0</code></a> <code>Update .travis.yml</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/sindresorhus/strip-indent/compare/459f98737dd57252ea63268c4686b939d40579ae...b537c94fd8376e4205146fbbef0bc08a477c5eab">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants