Sindre Sorhus sindresorhus

Developer Program Member

Organizations

@Modernizr @h5bp @editorconfig @gruntjs @yeoman @tastejs @webcomponents @aurajs @bower @gulpjs @tooling @certifi @imagemin @jscs-dev @babel @osscommunity @npm1k
@sindresorhus
@sindresorhus
Move 'DataView' to builtin
1 commit with 1 addition and 2 deletions
sindresorhus commented on pull request yeoman/generator-jquery#46
@sindresorhus

What is this PR supposed to improve? It's not clear.

@sindresorhus

No, negative has to be 1 indexed as slice: 'unicorn'.slice(-4) //=> 'corn'

sindresorhus commented on issue eslint/eslint#2667
@sindresorhus

Not sure, maybe something like: { "lines-around-comment": [2, {"beforeLineComment": true, "firstInBlock": false}] }

@sindresorhus
`lines-around-comment` exception for first line in a block
@sindresorhus
`no-process-exit` should be ignored in CLI's
sindresorhus commented on issue sindresorhus/pure#127
@sindresorhus

:+1:

@sindresorhus

Yeah, I agree. Better to be explicit.

@sindresorhus
@sindresorhus

The only way you can differentiate is the protocol /\w+:\/\//.test(str).

sindresorhus commented on pull request sindresorhus/gulp-mocha#94
@sindresorhus

if (!cache[key] && !/\.node$/.test(key)) {

sindresorhus commented on issue sindresorhus/pure#127
@sindresorhus

I actually added because I was so annoyed that so many tools didn't print the trailing newline.

@sindresorhus

But it does come with the node module rcedit that electron-packager depend on https://github.com/atom/node-rcedit/blob/master/bin/rcedit.exe We sho…

@sindresorhus

Addy is right. This is your solution: https://docs.npmjs.com/getting-started/fixing-npm-permissions Alternative guide, with even an optional script…

sindresorhus commented on pull request sindresorhus/awesome#173
@sindresorhus

:+1: Would be awesome if you could link back here in your list so users can easily discover more awesome lists ;)

@sindresorhus
@sindresorhus
Added a link to "Web Typography"
1 commit with 1 addition and 0 deletions
sindresorhus commented on pull request sindresorhus/awesome#174
@sindresorhus

Thanks. Looks good. Would be cool if you could link back here in your list so users can easily discover more awesome lists ;)

@sindresorhus
  • @sergeyklay a2bc9d1
    Close #174 PR: Added Phalcon.
@sindresorhus
Added Phalcon
sindresorhus commented on pull request sindresorhus/globals#33
@sindresorhus

:+1:

sindresorhus commented on pull request sindresorhus/query-string#24
@sindresorhus

You test seems to pass fine: https://travis-ci.org/sindresorhus/query-string/builds/64986110 Are you sure this is the query string lib you're using…

@sindresorhus
@sindresorhus

:+1: I liked it. Very original.

@sindresorhus
ensure correct parsing the query params with '='
sindresorhus commented on pull request sindresorhus/query-string#24
@sindresorhus

No idea what your "fix" is doing, but it's not correct. The reason it doesn't work is that supplying full URLs isn't supported yet: #15