add missing customer details #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgandhi1311
reviewed
Oct 26, 2023
| @@ -91,6 +91,9 @@ | |||
| "cf_company_id": { | |||
| "type": ["null", "integer", "string"] | |||
| }, | |||
| "cf_people_id": { | |||
| "type": ["null", "integer", "string"] | |||
There was a problem hiding this comment.
why do we need to keep multiple data types? Consider a scenario where the first record is of integer type, and the second record is of string type. Could this potentially result in a column split at the target?
There was a problem hiding this comment.
I have kept it inline with other id field cf_company_id considering that different tenants can can have these ids in numeric or alphanumeric format and hoping same tenant will have uniform format for ids so that very less probability of column split.
There was a problem hiding this comment.
Updated the schema for new fields as suggested.
added 5 commits
October 31, 2023 03:36
RushiT0122
force-pushed
the
add-missing-customer-details
branch
from
b0efe01 to
1e8eecf
Compare
sgandhi1311
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixed issue #98, added customer fields
business_entity_id,cf_people_id,tax_providers_fields.Manual QA steps
Risks
Rollback steps