Skip to content

Fix integration tests and schema refactoring #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shantanu73 merged 7 commits into from
Apr 29, 2024
Merged

Fix integration tests and schema refactoring #109

shantanu73 merged 7 commits into from
Apr 29, 2024

Conversation

@shantanu73
Copy link

@shantanu73 shantanu73 commented Apr 16, 2024 •
edited
Loading

Description of change

  1. Schema refactoring changes
  2. Fix integration tests to accommodate new discounts field in subscriptions schema

Manual QA steps

  • Ran tap-tester locally

Risks

  • No risk

Rollback steps

  • revert this branch

@rdeshmukh15
Copy link

rdeshmukh15 commented Apr 25, 2024 •
edited
Loading

What is the schema change exactly? I can only see spacing has changed in subscriptions.json
Please keep the refactoring changes in a different PR.

@shantanu73
Copy link
Author

shantanu73 commented Apr 26, 2024

What is the schema change exactly? I can only see spacing has changed in subscriptions.json Please keep the refactoring changes in a different PR.

@rdeshmukh15 updated the description, you may review again.

@shantanu73 shantanu73 changed the title Update subscription schema to include manual discounts Fix integration tests and schema refactoring Apr 26, 2024
@shantanu73 shantanu73 merged commit 0b571d1 into master Apr 29, 2024
nmdkalipi
nmdkalipi reviewed May 2, 2024
View reviewed changes
tests/test_chargebee_all_fields.py
Copy link

@nmdkalipi nmdkalipi May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was my comment deleted?

@nmdkalipi nmdkalipi mentioned this pull request May 2, 2024
Open
@dsprayberry dsprayberry deleted the include_discounts branch December 3, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdeshmukh15 rdeshmukh15 rdeshmukh15 approved these changes

+1 more reviewer

@nmdkalipi nmdkalipi nmdkalipi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shantanu73 @rdeshmukh15 @nmdkalipi