Skip to content

Update new_max_bookmark, Add unittests#30

Merged
dsprayberry merged 5 commits intomasterfrom
fix/do-not-store-future-dated-state-values
Sep 8, 2022
Merged

Update new_max_bookmark, Add unittests#30
dsprayberry merged 5 commits intomasterfrom
fix/do-not-store-future-dated-state-values

Conversation

@dsprayberry
Copy link
Copy Markdown
Contributor

@dsprayberry dsprayberry commented Sep 7, 2022

Description of change

  • Updates new_max_bookmark to check that we do not write future-dated bookmark values (as we've observed Closeio returning future-dated activities records even when passing the date_created__lt parameter on requests)
  • Adds unittests

Manual QA steps

  • added 2 unittests that validate new_max_bookmark functionality::
    • test_new_max_bookmark_valid_potential
    • test_new_max_bookmark_future_dated_potential

Risks

  • Minimal. State is stored in the same format, but it will no longer have the potential to be a datetime string greater than now().

Rollback steps

  • revert this branch

Copy link
Copy Markdown

@luandy64 luandy64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, but then this is good

Co-authored-by: Andy Lu <andy@stitchdata.com>
@dsprayberry dsprayberry merged commit bf53386 into master Sep 8, 2022
@dsprayberry dsprayberry deleted the fix/do-not-store-future-dated-state-values branch September 8, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants