Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed key error on companies, the API has changed but some data is st… #14

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Fixed key error on companies, the API has changed but some data is st… #14

merged 3 commits into from
Aug 11, 2022

Conversation

visch
Copy link
Contributor

@visch visch commented Apr 11, 2022

No description provided.

@visch
Fixed key error on companies, the API has changed but some data is st…
6e9d2b4 
…ill coming out of the tap so getting this out is better than the tap was before!
@visch visch mentioned this pull request Apr 11, 2022
Open
dmosorast
dmosorast requested changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Derek, the change looks good and seems like a quick fix. Can you remove the Meltano-specific stuff from the PR? I'd like to keep the singer-io repos and their readmes provider agnostic.

@visch
Revert "Fixed key error on companies, the API has changed but some da…
0e91a88 
…ta is still coming out of the tap so getting this out is better than the tap was before!"

This reverts commit 6e9d2b4.
@visch
Fixed companies stream
187583a
@visch
Copy link
Contributor Author

visch commented Aug 11, 2022

Hey Derek, the change looks good and seems like a quick fix. Can you remove the Meltano-specific stuff from the PR? I'd like to keep the singer-io repos and their readmes provider agnostic.

Done!

dmosorast
dmosorast approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, I do see this keyerror show up, so this should be rather straightforward.

@dmosorast dmosorast merged commit ae0120d into singer-io:master Aug 11, 2022
This was referenced Aug 11, 2022
Closed
Merged
@visch visch deleted the 13_key_error_companies branch August 15, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@econti econti econti approved these changes

@dmosorast dmosorast dmosorast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visch @econti @dmosorast