Fixed key error on companies, the API has changed but some data is st… - #14
Merged
Merged
Conversation
…ill coming out of the tap so getting this out is better than the tap was before!
econti
approved these changes
Aug 11, 2022
dmosorast
suggested changes
Aug 11, 2022
dmosorast
left a comment
dmosorast
left a comment
Contributor
There was a problem hiding this comment.
Hey Derek, the change looks good and seems like a quick fix. Can you remove the Meltano-specific stuff from the PR? I'd like to keep the singer-io repos and their readmes provider agnostic.
…ta is still coming out of the tap so getting this out is better than the tap was before!" This reverts commit 6e9d2b4.
Contributor
Author
Done! |
dmosorast
approved these changes
Aug 11, 2022
dmosorast
left a comment
dmosorast
left a comment
Contributor
There was a problem hiding this comment.
Seems good, I do see this keyerror show up, so this should be rather straightforward.
This was referenced Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.