New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update api to v3.5 #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KAllan357
reviewed
Jun 21, 2021
@@ -32,6 +32,7 @@ | |||
] | |||
|
|||
def main(): | |||
print("Fetching " + FIELD_DOC_URL, file=sys.stderr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logger?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just avoiding another import and since I had sys
already, I figured I would use it
KAllan357
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR updates the API version from v3.3 to v3.5 in accordance with Google's deprecation of v3.3.
Manual QA steps
Testing the Multiple Schema Handling
I was able to run the tap and add
uniqueReachAverageImpressionFrequency
to the report. This resulted in a Catalog withthe following schema in it
I was able to run a sync as well. For
uniqueReachAverageImpressionFrequency
, I was able to sync values"123.456"
and"some_field"
. The tap was able to convert these to"uniqueReachAverageImpressionFrequency": 123.456
and"uniqueReachAverageImpressionFrequency": "some_field"
respectively.And on the
"some_field"
values, I saw the warning I addedWARNING Failed parse field as double
.Finally, I ran the outputted records through
target-stitch
to compare the records to the schemaINFO avb_report (1636): Batch is valid
Risks
I noticed the following fields had schema changes
This has been addressed by including the old schema and the new schema in the catalog. So if a report will continue to pull a value like
123.456
, the tap won't try to convert it to a string and cause a column to split in a downstream system. The moment a string value for any of these fields occur though, expect your warehouse to have two columns to hold the data.Rollback steps