Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump facebook sdk to v10.0 #146

Merged
merged 8 commits into from May 25, 2021
Merged

bump facebook sdk to v10.0 #146

merged 8 commits into from May 25, 2021

Conversation

zachharris1
Copy link
Contributor

@zachharris1 zachharris1 commented Apr 13, 2021

Description of change

Bump the facebook sdk to v10.0

The only change we had to make is AdsInsights can only get data as old as 37 months ago.

Manual QA steps

  • Read over the changelog and searched for used terms
  • Tested that v9.0 access tokens work with the v10.0 sdk

Risks

  • low

Rollback steps

  • revert this branch

tap_facebook/__init__.py Outdated Show resolved Hide resolved
tap_facebook/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once tests pass, this seems good to me. It's possibly a bit risky depending on how confident we feel on our test coverage and changelog analysis, but hopefully with the retention period on the new API, it improves the stability. :shipit:

@cosimon cosimon merged commit f7d8b81 into master May 25, 2021
pull bot pushed a commit to admariner/tap-facebook that referenced this pull request May 25, 2021
* bump facebook sdk to v10.0

* limit lookback for insights to 37 months

* fix unit tests

* response to feedback

* remove old logging

Co-authored-by: Andy Lu <andy@stitchdata.com>
pull bot pushed a commit to admariner/tap-facebook that referenced this pull request May 25, 2021
* bump facebook sdk to v10.0

* limit lookback for insights to 37 months

* fix unit tests

* response to feedback

* remove old logging

Co-authored-by: Andy Lu <andy@stitchdata.com>
pull bot pushed a commit to admariner/tap-facebook that referenced this pull request May 25, 2021
* bump facebook sdk to v10.0

* limit lookback for insights to 37 months

* fix unit tests

* response to feedback

* remove old logging

Co-authored-by: Andy Lu <andy@stitchdata.com>
pull bot pushed a commit to admariner/tap-facebook that referenced this pull request May 25, 2021
* bump facebook sdk to v10.0

* limit lookback for insights to 37 months

* fix unit tests

* response to feedback

* remove old logging
jesuejunior pushed a commit to sixcodes/tap-facebook that referenced this pull request Mar 17, 2023
* bump facebook sdk to v10.0

* limit lookback for insights to 37 months

* fix unit tests

* response to feedback

* remove old logging

Co-authored-by: Andy Lu <andy@stitchdata.com>
jesuejunior pushed a commit to sixcodes/tap-facebook that referenced this pull request Mar 17, 2023
* bump facebook sdk to v10.0

* limit lookback for insights to 37 months

* fix unit tests

* response to feedback

* remove old logging

Co-authored-by: Andy Lu <andy@stitchdata.com>
jesuejunior pushed a commit to sixcodes/tap-facebook that referenced this pull request Mar 17, 2023
* bump facebook sdk to v10.0

* limit lookback for insights to 37 months

* fix unit tests

* response to feedback

* remove old logging

Co-authored-by: Andy Lu <andy@stitchdata.com>
jesuejunior pushed a commit to sixcodes/tap-facebook that referenced this pull request Mar 17, 2023
* bump facebook sdk to v10.0

* limit lookback for insights to 37 months

* fix unit tests

* response to feedback

* remove old logging
jesuejunior pushed a commit to sixcodes/tap-facebook that referenced this pull request Mar 17, 2023
* bump facebook sdk to v10.0

* limit lookback for insights to 37 months

* fix unit tests

* response to feedback

* remove old logging

Co-authored-by: Andy Lu <andy@stitchdata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants