Feature/retry insights job polling#174
Merged
Merged
Conversation
dmosorast
suggested changes
Nov 1, 2021
dmosorast
left a comment
dmosorast
left a comment
Contributor
There was a problem hiding this comment.
I think this might need a bit of a redesign to get a proper retry pattern set up.
dmosorast
suggested changes
Nov 2, 2021
| def api_get_with_retry(job): | ||
| job = job.api_get() | ||
| return job | ||
|
|
Contributor
There was a problem hiding this comment.
I'd move this closer to usage inside the class and mark it "private" in the python sense by prefixing with __.
Pylint will probably warn about no self usage, but I think you can use @staticmethod to stop that. So like:
@staticmethod
@retry_pattern(backoff.constant, FacebookRequestError, max_tries=5, interval=1)
def __api_get_with_retry(job):
job = job.api_get()
return job
Then the usage would be
AdsInsights.__api_get_with_retry(job)
Contributor
There was a problem hiding this comment.
The benefit of this is that it makes it clear that this is only for insights usage and to keep it localized for if we want to refactor the class into its own module.
dmosorast
approved these changes
Nov 2, 2021
jesuejunior
pushed a commit
to sixcodes/tap-facebook
that referenced
this pull request
Mar 17, 2023
* Add sleep and retry for insights job polling * correct dylans typo * added tests, got tests passing * Makes api_get_with_retry function that uses retry wrapper * Style changes * Style changes 2 * Version Bump * removed count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Adds sleep and retry to job polling. Creates new tests for consistent failure / retry and failure / eventual success.
Manual QA steps
Risks
Rollback steps