Bump facebook API to v14.0 #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosimon
requested changes
Oct 13, 2022
CHANGELOG.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| # Changelog | |||
|
|
|||
| ## 1.18.4 | |||
| * Facebook busines API to v15.0 [#201](https://github.com/singer-io/tap-facebook/pull/201) | |||
There was a problem hiding this comment.
You bumped it to v14.0, not v15.0
There was a problem hiding this comment.
@cosimon I went through the link : https://pypi.org/project/facebook-business/
Apparently latest sdk version is 14.0.0 and latest api version is 15.0, their sdk is not up to date with latest api version.
Also, I confirmed that versions previous to v15.0 are deprecated. How shall we proceed with this ?
cosimon
approved these changes
Oct 19, 2022
jamjensen
added a commit
to jamjensen/tap-facebook
that referenced
this pull request
Nov 20, 2022
v15 was released on 10/25, five days after singer-io#201 was approved to bump to v14
rarce
added a commit
to Datalized/tap-facebook
that referenced
this pull request
Feb 6, 2023
Bump facebook API to v14.0 (singer-io#201)
jesuejunior
added a commit
to sixcodes/tap-facebook
that referenced
this pull request
Mar 17, 2023
* Bump facebook API to v15.0 which is used in sdk facebook_business version 14.0.0 * New tap-facebook bump version 1.18.4 * changed Facebook API version to v14.0 * Bump Facebook API to v15.0 v15 was released on 10/25, five days after singer-io#201 was approved to bump to v14 --------- Co-authored-by: shantanu73 <shantanudhiman25@gmail.com> Co-authored-by: jamjensen <jamesronaldjensen@gmail.com>
jesuejunior
pushed a commit
to sixcodes/tap-facebook
that referenced
this pull request
Mar 17, 2023
* Bump facebook API to v14.0 which is used in sdk facebook_business version 14.0.0 * New tap-facebook bump version 1.18.4
jesuejunior
added a commit
to sixcodes/tap-facebook
that referenced
this pull request
Mar 28, 2023
* Add country to ads insights country breakdown PK * Remove `ads.creative.creative_id` in favor of `ads.creative.id` * Added missing test cases * Updated pagination test case * Removed pagination test case * Added back pagination test file * conversions * feature - add conversion to all streams * Jamjensen patch 1 (#8) * Bump facebook API to v15.0 which is used in sdk facebook_business version 14.0.0 * New tap-facebook bump version 1.18.4 * changed Facebook API version to v14.0 * Bump Facebook API to v15.0 v15 was released on 10/25, five days after singer-io#201 was approved to bump to v14 --------- Co-authored-by: shantanu73 <shantanudhiman25@gmail.com> Co-authored-by: jamjensen <jamesronaldjensen@gmail.com> --------- Co-authored-by: Dan Mosora <dan@stitchdata.com> Co-authored-by: vagrant <vagrant@vagrant.vm> Co-authored-by: Umang Agrawal <umang.agrawal@crestdatasys.com> Co-authored-by: Gary James <gary.james19@gmail.com> Co-authored-by: shantanu73 <shantanudhiman25@gmail.com> Co-authored-by: jamjensen <jamesronaldjensen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the facebook api version to v14.0
Description of change
(write a short description or paste a link to JIRA)
Manual QA steps
Risks
Rollback steps