-
Notifications
You must be signed in to change notification settings - Fork 141
Add conversions to insights streams #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @GtheSheep, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
You did it @GtheSheep! Thank you for signing the Singer Contribution License Agreement. |
Hi @GtheSheep, checking if this is still in progress? Looking forward to this getting merged so we can leverage conversions data. Thanks! |
Hey @beauchbum - I've been running this off my fork for a couple of months now and all seems well, not sure what else is required to get this merged other than for someone to review? |
@dsprayberry @luandy64 @kethan1122 - not sure what the process is to get this reviewed, any insight plz? |
@GtheSheep thanks for your contribution. I will review the change and get it deployed. |
@GtheSheep @beauchbum, the PR changes have been deployed to production. Could you verify on your end? Thank you! |
Description of change
Include schemas for conversions in insights tables
Remove duplicate "reach" in schema of ads_insights
Manual QA steps
Risks
Rollback steps