Skip to content

Upgrade to Marketing API V23 - #255

Merged
vishalp-dev merged 3 commits into
masterfrom
upgrade-marketing-api
Sep 3, 2025
Merged

vishalp-dev merged 3 commits into
masterfrom
upgrade-marketing-api

Conversation

@vishalp-dev

@vishalp-dev vishalp-dev commented Aug 29, 2025 •

Copy link
Copy Markdown
Member

Description of change

  • Replace/ Remove deprecated fields Changelog

Manual QA steps

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@vishalp-dev
vishalp-dev marked this pull request as draft August 29, 2025 05:51
@vishalp-dev vishalp-dev changed the title [Draft] Upgrade to Marketing API V23 Upgrade to Marketing API V23 Sep 1, 2025
@vishalp-dev
vishalp-dev marked this pull request as ready for review September 1, 2025 14:29
@vishalp-dev
vishalp-dev requested a review from Copilot September 2, 2025 09:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the Facebook Marketing API from version 21 to version 23, updating deprecated field names to their new equivalents as required by the API changelog.

Key changes:

  • Updated facebook_business SDK from v21.0.5 to v23.0.1
  • Replaced deprecated Instagram-related field names with their new counterparts
  • Updated version number from 1.23.0 to 1.24.0

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
setup.py Bumped version to 1.24.0 and updated facebook_business dependency to v23.0.1
tap_facebook/schemas/adcreative.json Replaced deprecated Instagram field names with new API v23 equivalents
tests/test_facebook_all_fields.py Updated test to use new field name for source_instagram_media_id
CHANGELOG.md Added changelog entry documenting the SDK upgrade and deprecated field removal

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vishalp-dev
vishalp-dev merged commit 9301639 into master Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants