Repository navigation
Upgrade to Marketing API V23 - #255
Merged
Merged
Conversation
vishalp-dev
marked this pull request as draft
August 29, 2025 05:51
vishalp-dev
marked this pull request as ready for review
September 1, 2025 14:29
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Facebook Marketing API from version 21 to version 23, updating deprecated field names to their new equivalents as required by the API changelog.
Key changes:
- Updated facebook_business SDK from v21.0.5 to v23.0.1
- Replaced deprecated Instagram-related field names with their new counterparts
- Updated version number from 1.23.0 to 1.24.0
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Bumped version to 1.24.0 and updated facebook_business dependency to v23.0.1 |
| tap_facebook/schemas/adcreative.json | Replaced deprecated Instagram field names with new API v23 equivalents |
| tests/test_facebook_all_fields.py | Updated test to use new field name for source_instagram_media_id |
| CHANGELOG.md | Added changelog entry documenting the SDK upgrade and deprecated field removal |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
prijendev
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code