Skip to content

Pin numpy version to avoid errors with 2.X#6

Merged
leslievandemark merged 3 commits intomasterfrom
TDL-26549/pin-numpy
Dec 4, 2024
Merged

Pin numpy version to avoid errors with 2.X#6
leslievandemark merged 3 commits intomasterfrom
TDL-26549/pin-numpy

Conversation

@leslievandemark
Copy link
Copy Markdown
Contributor

@leslievandemark leslievandemark commented Dec 4, 2024

Description of change

The latest numpy versions are not compatible with current dependencies, this pr pins numpy to an older version.

Error without pinned version:

24-12-04 18:59:49,587Z tap - A module that was compiled using NumPy 1.x cannot be run in
2024-12-04 18:59:49,587Z tap - NumPy 2.0.2 as it may crash. To support both 1.x and 2.x
2024-12-04 18:59:49,587Z tap - versions of NumPy, modules must be compiled with NumPy 2.0.
2024-12-04 18:59:49,587Z tap - Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.
2024-12-04 18:59:49,587Z tap -
2024-12-04 18:59:49,587Z tap - If you are a user of the module, the easiest solution will be to
2024-12-04 18:59:49,587Z tap - downgrade to 'numpy<2' or try to upgrade the affected module.
2024-12-04 18:59:49,587Z tap - We expect that some modules will need time to support NumPy 2.

Manual QA steps

  • Saw errors resolved by building docker container with pinned numpy 1.x version

Risks

  • low

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@leslievandemark leslievandemark merged commit 71984f9 into master Dec 4, 2024
@leslievandemark leslievandemark deleted the TDL-26549/pin-numpy branch December 4, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants