Skip to content

Force advertiserAdCostPerKeyEvent to have no exclusions for now#106

Merged
cosimon merged 3 commits intomainfrom
fix/field-exclusion-update
Jan 6, 2025
Merged

Force advertiserAdCostPerKeyEvent to have no exclusions for now#106
cosimon merged 3 commits intomainfrom
fix/field-exclusion-update

Conversation

@luandy64
Copy link
Copy Markdown

@luandy64 luandy64 commented Jan 6, 2025

Description of change

This PR is a reaction to failing discovery tap runs. There seems to be no code change from Google and no recent tap updates.

Manual QA steps

  • Ran discovery

Risks

  • Not sure. This unblocks things for now, but who knows for how long.

Rollback steps

  • revert this branch, bump the tap version

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@cosimon cosimon merged commit 20ed78c into main Jan 6, 2025
@cosimon cosimon deleted the fix/field-exclusion-update branch January 6, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants