TDL-21347 Filter non-ascii non-alphanumeric metric names - #28
Merged
Conversation
dsprayberry
approved these changes
Nov 22, 2022
leslievandemark
approved these changes
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Custom event-scoped metrics with non-ascii non-alphanumeric names can be created in the GA4 console. These characters are currently incompatible with Google's Data API.
example:
The parentheses in a metric named
conversion:(other)causes this response:See: https://support.google.com/analytics/thread/176551995/conversion-event-api-calls-should-use-event-id-not-name-sessionconversionrate-conversion-event-name
This change filters the bad metric names so a connection can successfully complete the check. The bad metrics will be marked unsupported in field selection.
Manual QA steps
Risks
Rollback steps