Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for base details, such as 'ref', 'repo', 'label' and 'sha' #109

Merged

Conversation

felipefrancisco
Copy link
Contributor

@felipefrancisco felipefrancisco commented Apr 9, 2021

Description of change

Adds the base node to the pull_requests.json definition. It includes the following new fields:

  • base.ref (so now we can tell where pull requests are targeted)
  • base.label
  • base.sha
  • base.repo.id
  • base.repo.name
  • base.repo.url

My test produced the following added result:

...
{
   "base":{
      "label":"felipefrancisco:master",
      "ref":"master",
      "sha":"0d77a1034b9dbf08b8f91369a65c13b9c726c722",
      "repo": {
         "id":215760822.0,
         "name":"analytics",
         "url":"https://api.github.com/repos/felipefrancisco/analytics"
      }
   }
}
...

The fields added to the pull_requests.json is directly matching the documentation provided in Github's official docs for the List Pull Requests endpoint:

https://docs.github.com/en/rest/reference/pulls#list-pull-requests

Manual QA steps

  • Follow the initial configuration steps in the README
  • Add the base node from this PR to your properties.json
  • Run tap-github --config config.json --properties properties.json and see the changes

Risks

  • None identified

Rollback Steps

  • Revert this branch

@cmerrick
Copy link
Contributor

cmerrick commented Apr 9, 2021

Hi @felipefrancisco, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@felipefrancisco felipefrancisco marked this pull request as draft April 9, 2021 23:09
@cmerrick
Copy link
Contributor

cmerrick commented Apr 9, 2021

You did it @felipefrancisco!

Thank you for signing the Singer Contribution License Agreement.

@felipefrancisco felipefrancisco changed the title add support for base details, such as 'ref', 'repo', 'label' and 'sha' Add support for base details, such as 'ref', 'repo', 'label' and 'sha' Apr 9, 2021
@felipefrancisco felipefrancisco marked this pull request as ready for review April 9, 2021 23:42
tap_github/schemas/pull_requests.json Outdated Show resolved Hide resolved
tap_github/schemas/pull_requests.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants