TDL-16349: Add request timeout #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,7 +48,8 @@ This tap: | |||
| ```json | |||
There was a problem hiding this comment.
Add the description for the request_timeout in point 3
umangagrawal-crest
suggested changes
Nov 17, 2021
When we import |
tap_github/__init__.py
Outdated
| config_request_timeout = args.config.get('request_timeout') | ||
|
|
||
| if config_request_timeout and float(config_request_timeout): | ||
| request_timeout = float(config_request_timeout) |
There was a problem hiding this comment.
Add detailed comment above if condition.
tap_github/__init__.py
Outdated
Comment on lines
1027
to
1029
| request_timeout = float(config_request_timeout) | ||
| # return the timeout from config | ||
| return request_timeout |
There was a problem hiding this comment.
Suggested change
| request_timeout = float(config_request_timeout) | |
| # return the timeout from config | |
| return request_timeout | |
| return float(config_request_timeout) |
savan-chovatiya
approved these changes
Nov 26, 2021
umangagrawal-crest
approved these changes
Nov 29, 2021
namrata270998
approved these changes
Nov 29, 2021
karanpanchal-crest
approved these changes
Dec 1, 2021
umangagrawal-crest
requested review from
KrisPersonal,
kspeer825 and
manand31
KrisPersonal
approved these changes
Dec 1, 2021
kspeer825
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-16349: Add request timeout
Manual QA steps
Risks
Rollback steps