Tdl 26656 transform state#212
Merged
leslievandemark merged 15 commits intomasterfrom Jan 13, 2025
Merged
Conversation
luandy64
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Tap-github supports multiple repositories. The previous bookmark format for tap was:
{bookmarks {repository {stream_name ...}}}In order to support stream level resets, we need to switch the bookmark format to:
{bookmarks {stream_name {repository ...}}}This pr update the
translate_statefunction to convert old bookmarks into the new state. New connections will have the new format automatically.Manual QA steps
Risks
{bookmarks {stream_name {bookmark_values...}}}to{bookmarks {repository {stream_name ...}}}. There are 13 connection that still have the old old bookmark format, but they are all either on non-active accounts or paused an require a major version bump. In this update the old old bookmark format is not accommodated, it should be impossible for a connection with that format to run this code, but if I missed something and it happens the tap would error.Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code