Skip to content

Add call_details stream#49

Merged
dsprayberry merged 8 commits into
mainfrom
add-core-streams
Apr 22, 2022
Merged

Add call_details stream#49
dsprayberry merged 8 commits into
mainfrom
add-core-streams

Conversation

@bryantgray

Copy link
Copy Markdown
Contributor

Description of change

  • Remove segments from core streams
    • campaign_budgets is the only stream affected; removed the segment campaign_id
    • Any campaign_budgets not linked to a campaign will now be returned
  • Add call_details core stream

QA steps

  • automated tests passing
  • manual qa steps passing

Risks

  • Users who had selected the campaign_budgets stream will no longer receive campaign_id

Rollback steps

  • revert this branch

@kspeer825 kspeer825 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment request for the tests, very minor

Comment thread tests/test_google_ads_automatic_fields.py Outdated
Comment thread tests/test_google_ads_bookmarks.py Outdated
bryantgray and others added 2 commits April 21, 2022 17:00
@dsprayberry dsprayberry requested a review from kspeer825 April 21, 2022 20:14

@kspeer825 kspeer825 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are good 👍

@dsprayberry dsprayberry merged commit 06c7f3e into main Apr 22, 2022
@dsprayberry dsprayberry deleted the add-core-streams branch April 22, 2022 16:10
@dsprayberry dsprayberry mentioned this pull request Apr 22, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants