Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/premade reports #16

Merged
merged 15 commits into from Apr 7, 2020
Merged

Feature/premade reports #16

merged 15 commits into from Apr 7, 2020

Conversation

dmosorast
Copy link
Contributor

Description of change

Adds premade report definitions to discovery mode for getting started with google analytics data.

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    • Ran discovery with a basic report and got selected-by-default working.

Risks

  • Low, this is a feature addition.

Rollback steps

  • revert this branch

@dmosorast
WIP working premade_report discovery
834e68a
@dmosorast
Fill in premade reports metrics/dimensions, auto-select first 10 metr…
b51d7a7 
…ics and ga:date
@dmosorast
Use selected-by-default for building report request
5ef8736
@dmosorast
Syntax error and add default dimensions
8cbb61a
@dmosorast
Pylint
2b04dde
@dmosorast
Change reports to be inclusive of today and fix default selection
97cdd9a
@dmosorast
Add premade reports to test expectations
f0b2462
@dmosorast
Add premade reports to expected PKs
9419c32
@dmosorast
Add spike file for finding valid metric and dimension combos
280f18e
@dmosorast
Parse and print out winners in spike
e0d2412
@dmosorast
Extend spike and change dimensions for acquisition overview
5196721
@dmosorast
Remove date from default dimensions
ae8be71
@dmosorast
Fix acquisition overview metrics and remove default 'report'
01b9ea3
@dmosorast
Make dimension getting safe, since google analytics doesn't require them
10dab5d
@dmosorast
Fix test
779fc31
@dmosorast dmosorast merged commit f4cdcdb into master Apr 7, 2020
@dmosorast dmosorast deleted the feature/premade_reports branch April 7, 2020 17:25
@dmosorast dmosorast mentioned this pull request Apr 7, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luandy64 luandy64 luandy64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmosorast @luandy64