Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] sync_endpoint: define update_at inside the loop and remove duplicated output #21

Merged
merged 2 commits into from Jun 8, 2021

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Jun 5, 2021

Description of change

Currently, sync_endpoints method fails because it is trying to access rec but it was not declared yet, it is declared inside the loop.

Another issue now is that the output has a lot of duplicated items.

The current PR fixes both issues.

Manual QA steps

Risks

Rollback steps

  • revert this branch

@cmerrick
Copy link
Contributor

cmerrick commented Jun 5, 2021

Hi @xmnlab, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@xmnlab xmnlab marked this pull request as draft June 5, 2021 13:10
@cmerrick
Copy link
Contributor

cmerrick commented Jun 5, 2021

You did it @xmnlab!

Thank you for signing the Singer Contribution License Agreement.

@xmnlab xmnlab marked this pull request as ready for review June 7, 2021 21:55
@xmnlab
Copy link
Contributor Author

xmnlab commented Jun 7, 2021

I think now that this PR is ready for review. thanks!

@xmnlab xmnlab changed the title sync_endpoint: define update_at inside the loop and remove duplicated output [BUG] sync_endpoint: define update_at inside the loop and remove duplicated output Jun 8, 2021
@kcpevey
Copy link

kcpevey commented Jun 8, 2021

Thanks for opening this @xmnlab! It will unblock me :)

@leslievandemark leslievandemark merged commit ab84334 into singer-io:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants