Tdl 24590 fix contacts to company #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 17, 2024 15:06
…590-fix-contacts-to-company
…590-fix-contacts-to-company
…-io/tap-hubspot into TDL-24590-fix-contacts-to-company
cosimon
reviewed
Jan 22, 2024
tap_hubspot/__init__.py
Outdated
| "companies_all": "/companies/v2/companies/paged", | ||
| "companies_recent": "/companies/v2/companies/recent/modified", | ||
| "companies_detail": "/companies/v2/companies/{company_id}", | ||
| "contacts_by_company": "/companies/v2/companies/{company_id}/vids", |
cosimon
approved these changes
Jan 22, 2024
rdeshmukh15
reviewed
Jan 22, 2024
| @@ -1,5 +1,8 @@ | |||
| # Changelog | |||
|
|
|||
| ## 2.13.1 | |||
Contributor
There was a problem hiding this comment.
in setup.py version mentioned is 2.14.0 and here it is 2.13.1
These should be in sync
rdeshmukh15
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Currently we make a request to retrieve
contacts_by_companypercompany_id. But this results in performance issue TDL-24590, if we have large number of company ids. To overcome this issue, we will make one request for 250 company ids in a batch to retrievecontacts_by_companywhich will reduce number ofcontacts_by_companyrequests almost by 250 times.Manual QA steps
contacts_by_companyto simulate existing connection scenariocontacts_by_companyoffset is lesser thancompaniesoffsetcontacts_by_companyoffset is greater thancompaniesoffset (observed this scenario in internal testing)Risks
Rollback steps