Skip to content

TDL-26642: Support new properties foe deals stream#265

Merged
prijendev merged 5 commits intomasterfrom
TDL-26643-support-new-properties-for-deals-stream
Oct 28, 2024
Merged

TDL-26642: Support new properties foe deals stream#265
prijendev merged 5 commits intomasterfrom
TDL-26643-support-new-properties-for-deals-stream

Conversation

@prijendev
Copy link
Contributor

@prijendev prijendev commented Oct 22, 2024

Description of change

In the tap-HubSpot integration, we currently fetch the properties schema dynamically for certain streams, including contacts and deals. Starting from November 20, certain API properties will no longer be returned.

  • hs_lifecyclestage_{stage id}
  • hs_date_entered_{stage id}
  • hs_date_exited_{stage id}
  • hs_time_in_{stage id}

Instead, we will need to rely on the new set of properties.

  • hs_v2_date_entered_{stage_id}
  • hs_v2_date_exited_{stage_id}
  • hs_v2_latest_time_in_{stage_id}
  • Hs_v2_cumulative_time_in_{stage_id}

Since these are dynamic properties, we have both sets of properties present in the schema at the moment. We just need to update the code for the deals stream to ensure that only the newly required properties are requested going forward.

Manual QA steps

  • Run the discover mode and verify the generated catalog.
  • Run the sync mode and verify the records.
  • Run the sync mode and verify the state.

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@prijendev prijendev marked this pull request as ready for review October 24, 2024 09:46
@prijendev prijendev merged commit 67324fc into master Oct 28, 2024
@lrodriguezesc
Copy link

lrodriguezesc commented Nov 4, 2024

@prijendev Does this mean previous versions of the Hubspot tap will break on November 20th, or will old fields just not be returned?

@dsprayberry dsprayberry deleted the TDL-26643-support-new-properties-for-deals-stream branch August 14, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants