TDL-26642: Support new properties foe deals stream#265
Merged
Conversation
sgandhi1311
approved these changes
Oct 28, 2024
|
@prijendev Does this mean previous versions of the Hubspot tap will break on November 20th, or will old fields just not be returned? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
In the tap-HubSpot integration, we currently fetch the properties schema dynamically for certain streams, including contacts and deals. Starting from November 20, certain API properties will no longer be returned.
Instead, we will need to rely on the new set of properties.
Since these are dynamic properties, we have both sets of properties present in the schema at the moment. We just need to update the code for the deals stream to ensure that only the newly required properties are requested going forward.
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code