Skip to content

Explicitly Deselect Unselected Fields - #266

Merged
RushiT0122 merged 9 commits into
masterfrom
TDL-26900-fix-contacts-field-discrepancy
Feb 20, 2025
Merged

RushiT0122 merged 9 commits into
masterfrom
TDL-26900-fix-contacts-field-discrepancy

Conversation

@RushiT0122

@RushiT0122 RushiT0122 commented Jan 9, 2025 •

Copy link
Copy Markdown
Contributor

Description of change

TDL-26872: Fixes the extraction of unselected fields for all streams by explicitly deselecting fields in the catalog metadata.

Manual QA steps

Existing connections:

Without making any changes in settings,

  1. App should have new select_fields_by_default checkbox checked by default
  2. Orchestrator should not write new property select_fields_by_default in tap config
  3. Tap extracts newly discovred fields

After unhecking the select_fields_by_default

  1. App should have new select_fields_by_default uncheckbox checked
  2. Tap should read new property equal to `select_fields_by_default==False'
  3. Tap doesn't sync extracts newly discovered fields

New connections:

  1. App should have new select_fields_by_default uncheckbox checked
  2. Tap should read new property equal to `select_fields_by_default==False'
  3. Tap doesn't sync extracts newly discovered fields

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@RushiT0122
RushiT0122 marked this pull request as ready for review January 9, 2025 10:56
@RushiT0122
RushiT0122 merged commit 155e753 into master Feb 20, 2025
@dsprayberry
dsprayberry deleted the TDL-26900-fix-contacts-field-discrepancy branch August 14, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants