Set Default start_date to 3 Years Ago for actions and actionUpdates#33
Merged
Conversation
…e it default to now minus 3 years
rdeshmukh15
changed the title
rdeshmukh15
changed the title
RushiT0122
requested changes
Sep 27, 2024
RushiT0122
left a comment
RushiT0122
left a comment
There was a problem hiding this comment.
IMO, we should fail the discovery if date is older than 3 years.
Member
Author
This rule of having start_date only upto 3 years is for Actions and ActionUpdates. |
* remove implementation of clicks as it is deprecated * pylint fix * Date window implementation for actions and actionUpdates (#35) * date window of 45 days implemented for actions and actionUpdates * refactoring * change default windowing range to 45 days for actions and action_updates * refactoring * change in comment --------- Co-authored-by: “rdeshmukh15” <“rutuja.deshmukh@qlik.com”> --------- Co-authored-by: “rdeshmukh15” <“rutuja.deshmukh@qlik.com”>
updated-dependencies: - dependency-name: requests dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rutuja Deshmukh <107538720+rdeshmukh15@users.noreply.github.com>
- Updates the requests to latest version
RushiT0122
reviewed
Dec 9, 2024
RushiT0122
reviewed
Dec 9, 2024
RushiT0122
reviewed
Dec 10, 2024
RushiT0122
reviewed
Dec 10, 2024
RushiT0122
approved these changes
Dec 10, 2024
vishalp-dev
reviewed
Dec 11, 2024
| BASE_URL = 'https://api.impact.com' | ||
| # Window size implemented for actions and actionUpdates streams | ||
| # as startDate and EndDate can just be 45 days apart | ||
| DEFAULT_WINDOW_SIZE = 45 |
Member
There was a problem hiding this comment.
any specific reason to keep it 45 days? rather than a standard 1 month or 30 days date window?
Member
Author
There was a problem hiding this comment.
This is the PR referenced in description which tells about this in detail: #35
vishalp-dev
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
According to the impact document at: https://integrations.impact.com/impact-brand/changelog/changes-to-actions-and-action-updates, new changes were implemented on August 5, 2024. One of these changes states that queries for Actions or ActionUpdates cannot have a StartDate that is more than 3 years old.
As a result of this restriction, customers began encountering errors when the start_date specified in their configuration
is older than 3 years. The error message is as follows:
Hence, as part of fix, added a default start_date to 3 years ago when start_date is more than 3 years old.
remove implementation of clicks stream as it is deprecated #34
Date window implementation for actions and actionUpdates #35
Bump requests from 2.31.0 to 2.32.0 #28
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code