Skip to content

change page_size to default value 20000#36

Merged
rdeshmukh15 merged 2 commits into
masterfrom
TDL-26912/change-page-size
Jan 16, 2025
Merged

change page_size to default value 20000#36
rdeshmukh15 merged 2 commits into
masterfrom
TDL-26912/change-page-size

Conversation

@rdeshmukh15
Copy link
Copy Markdown
Member

Description of change

  • changes value of page_size to 20000
  • bump version changes in CHANGELOG.md and setup.py

Manual QA steps

Risks

  • low

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

Comment thread tap_impact/sync.py Outdated
endpoint_total = 0
total_records = 0
limit = 1000 # PageSize (default for API is 100)
limit = 20000 # PageSize (default for API is 20000)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
limit = 20000 # PageSize (default for API is 20000)
limit = 20000 # Default API page size

@rdeshmukh15 rdeshmukh15 merged commit bb54fa9 into master Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants