Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing groups and applicationRoles from users schema #41

Merged
merged 2 commits into from Aug 21, 2019

Conversation

@dmosorast
Copy link
Contributor

commented Aug 20, 2019

The endpoint as-is will not return these values. Syncing this data from Users would take a fundamental change in how the tap requests Users, so the fields are being removed.

This PR also updates the users schema to match the UserDetails object described under the PageBeanUserDetails response object in Groups -> Get users from groups here

More Info

The tap currently syncs users based on group using the group/member endpoint and values that are specified in the config, or a constant list here. According to the Jira API documentation, this returns a UserDetails object.

The groups and applicationRoles data exists on the /user endpoint (docs, Users -> Get Users on left hand menu). Since this can only get one user, it'd require a redesign to get the data efficiently.

@dmosorast dmosorast merged commit 827cd03 into master Aug 21, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@dmosorast dmosorast deleted the fix/remove-unavailable-fields-from-users branch Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.