Add request timeout #71
Conversation
| request_timeout = float(config_request_timeout) | ||
| else: | ||
| # If value is 0, "0", "", or not passed then it set default to 300 seconds | ||
| request_timeout = REQUEST_TIMEOUT |
There was a problem hiding this comment.
Is there a reason we use float() but the default value is an integer?
There was a problem hiding this comment.
I used the reference implementation from tap-harvest as listed in the jira issue. I would agree that it is a bit weird to cast to float by default, my guess would be this would avoid potential precision loss if we cast to an integer instead.
However the differences in precision would be negligible for this use case anyway. I can change to int() instead to make it consistent.
There was a problem hiding this comment.
When we tested the code with integer datatype and passed the value of request_timeout as "120.0" in the config file, then the below error message is thrown.
CRITICAL invalid literal for int() with base 10: '120.0'.
Also, we were not sure about the data type returned from the UI. So, to handle all the scenarios we used float datatype
Description of change
Added
request_timeoutto tap http client as per TDL-16581Manual QA steps
Risks
Rollback steps