TDL-16323: Add request timeout #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 12, 2021 18:16
umangagrawal-crest
suggested changes
Nov 18, 2021
umangagrawal-crest
left a comment
umangagrawal-crest
left a comment
There was a problem hiding this comment.
@harshpatel4crest Please update the readme and sample config file
Contributor
Author
Updated readme file and sample config file. |
| # get the value of request timeout from config | ||
| config_request_timeout = args.config.get('request_timeout') | ||
|
|
||
| if config_request_timeout and float(config_request_timeout): |
Contributor
There was a problem hiding this comment.
Add detailed comment over if condition.
Contributor
There was a problem hiding this comment.
I can't see the meaning of using the request_timeout variable.
Contributor
Author
There was a problem hiding this comment.
Updated the code and returned the value directly.
tap_klaviyo/utils.py
Outdated
Comment on lines
202
to
204
| request_timeout = float(config_request_timeout) | ||
| # return the timeout from config | ||
| return request_timeout |
Contributor
There was a problem hiding this comment.
Suggested change
| request_timeout = float(config_request_timeout) | |
| # return the timeout from config | |
| return request_timeout | |
| return float(config_request_timeout) |
tests/unittests/test_timeout.py
Outdated
| except requests.Timeout: | ||
| pass | ||
|
|
||
| # verfiy that we backoff for 5 times |
Contributor
There was a problem hiding this comment.
Suggested change
| # verfiy that we backoff for 5 times | |
| # verify that we backoff for 5 times |
tests/unittests/test_timeout.py
Outdated
| except requests.ConnectionError: | ||
| pass | ||
|
|
||
| # verfiy that we backoff for 5 times |
Contributor
There was a problem hiding this comment.
Suggested change
| # verfiy that we backoff for 5 times | |
| # verify that we backoff for 5 times |
savan-chovatiya
approved these changes
Nov 26, 2021
umangagrawal-crest
approved these changes
Nov 29, 2021
namrata270998
approved these changes
Nov 29, 2021
namrata270998
approved these changes
Nov 29, 2021
karanpanchal-crest
approved these changes
Dec 1, 2021
umangagrawal-crest
requested review from
KrisPersonal,
kspeer825 and
manand31
KrisPersonal
approved these changes
Dec 1, 2021
kspeer825
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-16323: Add request timeout
Manual QA steps
Risks
Rollback steps