Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-16348: Add request timeout #36

Merged
merged 11 commits into from
Jan 10, 2022
Merged

TDL-16348: Add request timeout #36

merged 11 commits into from
Jan 10, 2022

Conversation

hpatel41
Copy link
Contributor

@hpatel41 hpatel41 commented Nov 12, 2021

Description of change

TDL-16348: Add request timeout

  • Use default timeout of 300 seconds if the user does not enter the preferred timeout value

Manual QA steps

Risks

Rollback steps

  • revert this branch

@hpatel41 hpatel41 marked this pull request as ready for review November 15, 2021 07:45
@hpatel41 hpatel41 changed the title Add request timeout TDL-16348: Add request timeout Nov 15, 2021
Comment on lines 129 to 131
timeout_value = float(timeout_from_config)
# update the request timeout for the requests
self.request_timeout = timeout_value
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
timeout_value = float(timeout_from_config)
# update the request timeout for the requests
self.request_timeout = timeout_value
self.request_timeout = float(timeout_from_config)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.


# during 'Timeout' error there is also possibility of 'ConnectionError',
# hence added backoff for 'ConnectionError' too.
@backoff.on_exception(backoff.expo,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshpatel4crest Add comment that why we have added backoff here instead of check_access_token()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@hpatel41
Copy link
Contributor Author

hpatel41 commented Dec 1, 2021

The build is failing because the token used in the CircleCi has expired.

@KrisPersonal KrisPersonal merged commit 4853e5f into master Jan 10, 2022
@dsprayberry dsprayberry deleted the add-request-timeout branch April 10, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants