TDL-16348: Add request timeout#36
Merged
Merged
Conversation
Comment on lines
+129
to
+131
| timeout_value = float(timeout_from_config) | ||
| # update the request timeout for the requests | ||
| self.request_timeout = timeout_value |
Contributor
There was a problem hiding this comment.
Suggested change
| timeout_value = float(timeout_from_config) | |
| # update the request timeout for the requests | |
| self.request_timeout = timeout_value | |
| self.request_timeout = float(timeout_from_config) |
savan-chovatiya
approved these changes
Nov 26, 2021
|
|
||
| # during 'Timeout' error there is also possibility of 'ConnectionError', | ||
| # hence added backoff for 'ConnectionError' too. | ||
| @backoff.on_exception(backoff.expo, |
There was a problem hiding this comment.
@harshpatel4crest Add comment that why we have added backoff here instead of check_access_token()
Contributor
Author
|
The build is failing because the token used in the CircleCi has expired. |
namrata270998
approved these changes
Dec 17, 2021
KrisPersonal
approved these changes
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
TDL-16348: Add request timeout
Manual QA steps
Risks
Rollback steps