Add access token introspection to avoid new access token fetch if feasible #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachharris1
approved these changes
Sep 22, 2022
zachharris1
reviewed
Sep 23, 2022
|
Merged in lieu of tests passing because tests passed on local, and automation is in a state right now that's not able to be quickly fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
LinkedIn seemingly does not appreciate when we fetch new access tokens while a valid one already exists. This has been observed to exhibit itself in the form of 429 errors suggesting that a user has reached a rate limit while trying to use a refresh token to fetch a new access token in discovery.
This change checks the expiration of an existing access_token (if one is present in the config) and proceeds with that token if so.
Manual QA steps
Risks
Rollback steps