Skip to content

TDL-22682 Update API version and FIELDS_UNACCEPTED_BY_API #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2023
Merged

TDL-22682 Update API version and FIELDS_UNACCEPTED_BY_API #61

merged 3 commits into from
Apr 11, 2023

Conversation

dsprayberry
Copy link
Contributor

@dsprayberry dsprayberry commented Apr 10, 2023 •
edited
Loading

Description of change

  • Updates the API version to support fields previously considered beta by Microsoft.
  • LINKEDIN_VERSION global added to ensure consistent versioning throughout client.py
  • Moves FIELDS_UNACCEPTED_BY_API to remove filtered fields from field selection
  • Updates FIELDS_UNACCEPTED_BY_API to allow for replication of approximate_unique_impressions
  • Updates tests for version bump

Manual QA steps

  • Tested with local connection

Risks

  • Minimal; version bump is now set via global for ease of use

Rollback steps

  • revert this branch

@dsprayberry dsprayberry merged commit 3e07935 into master Apr 11, 2023
@dsprayberry dsprayberry deleted the fix/approximate_unique_impressions_no_longer_beta branch April 11, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leslievandemark leslievandemark leslievandemark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsprayberry @leslievandemark