fix convert_custom_fields to handle lists as well as dicts#47
Merged
leslievandemark merged 4 commits intomasterfrom Jun 3, 2021
Merged
fix convert_custom_fields to handle lists as well as dicts#47leslievandemark merged 4 commits intomasterfrom
convert_custom_fields to handle lists as well as dicts#47leslievandemark merged 4 commits intomasterfrom
Conversation
KAllan357
reviewed
Jun 3, 2021
tap_mambu/transform.py
Outdated
| i = i + 1 | ||
| return new_json | ||
| for key, value in record.items(): | ||
| if key[0] == '_': |
Contributor
There was a problem hiding this comment.
This should probably be startswith just to make it more clear.
KAllan357
approved these changes
Jun 3, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Fixed
convert_custom_fieldsto handle lists as well as dictionaries and added the tests to circleManual QA steps
Risks
Rollback steps