Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix convert_custom_fields to handle lists as well as dicts #47

Merged
merged 4 commits into from Jun 3, 2021

Conversation

leslievandemark
Copy link
Contributor

@leslievandemark leslievandemark commented Jun 2, 2021

Description of change

Fixed convert_custom_fields to handle lists as well as dictionaries and added the tests to circle

Manual QA steps

  • Ran the tap

Risks

Rollback steps

  • revert this branch

i = i + 1
return new_json
for key, value in record.items():
if key[0] == '_':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be startswith just to make it more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants