Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc bug fixes and features, continued the refactor #68

Merged
merged 6 commits into from
Mar 1, 2022

Conversation

DownstreamDataTeam
Copy link
Contributor

Description of change

  • added currency field to loan_accounts
  • added payment_details field to deposit_transactions
  • added status field to tasks stream
  • added sorting to gl_journal_entries stream to fix missing record at large extractions (very big offset)
  • fixed loan accounts being skipped if updated while the extraction is running
  • replaced endpoint_config dict with class properties
  • created unit tests for auxiliary functions
  • added logging to refactored code
  • implemented unit tests and functional tests for loan_accounts and loan_repayments streams
  • refactored deposit_accounts and cards streams (including unit tests)

Manual QA steps

  • compared Tap output before and after the changes
  • ran unit tests and Tap Tester

Rollback steps

  • revert this branch

Pull changes from Stitch

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!32
@cmerrick
Copy link
Contributor

Hi @DownstreamDataTeam, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

Radu Marinoiu added 4 commits February 22, 2022 15:48
release/37 changes, squashed

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!37
[ECDDC-625] Moved unit tests to outside of the TapTester tests folder

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!46
backoff
mock
requests
singer_python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with the setup.py already in use. Pip should pick up these requirements (except for mock, which is a test requirement) when running pip install -e . (with the -e meaning installing from source)

@@ -0,0 +1,4 @@
backoff
mock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be only installed during test running, in setup.py, we'd usually put this into a 'test' extras, much like the 'dev' one specified here: https://github.com/DownstreamDataTeam/tap-mambu/blob/release/37/setup.py#L16-L22

@@ -0,0 +1,3 @@
pytest
coverage
pylint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be under a test profile in setup.py, as mentioned above. To keep it at only one way to install dependencies in the repo.

For running the tests with the gitlab-ci config (or circleci, which I can update after merge), you can use pip install -e .[test] to install the test profile dependencies along with the tap's regular dependencies.

@dmosorast dmosorast merged commit ab39b05 into singer-io:master Mar 1, 2022
DownstreamDataTeam pushed a commit to DownstreamDataTeam/tap-mambu that referenced this pull request Mar 2, 2022
Misc bug fixes and features, continued the refactor (singer-io#68)

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!49
@singer-bot
Copy link

You did it @DownstreamDataTeam!

Thank you for signing the Singer Contribution License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants