-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc bug fixes and features, continued the refactor #68
Conversation
Pull changes from Stitch See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!32
Hi @DownstreamDataTeam, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
8ab97ab
to
986619a
Compare
release/37 changes, squashed See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!37
[ECDDC-625] Moved unit tests to outside of the TapTester tests folder See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!46
backoff | ||
mock | ||
requests | ||
singer_python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This conflicts with the setup.py
already in use. Pip should pick up these requirements (except for mock, which is a test requirement) when running pip install -e .
(with the -e meaning installing from source)
@@ -0,0 +1,4 @@ | |||
backoff | |||
mock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be only installed during test running, in setup.py, we'd usually put this into a 'test'
extras, much like the 'dev'
one specified here: https://github.com/DownstreamDataTeam/tap-mambu/blob/release/37/setup.py#L16-L22
@@ -0,0 +1,3 @@ | |||
pytest | |||
coverage | |||
pylint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be under a test
profile in setup.py, as mentioned above. To keep it at only one way to install dependencies in the repo.
For running the tests with the gitlab-ci config (or circleci, which I can update after merge), you can use pip install -e .[test]
to install the test profile dependencies along with the tap's regular dependencies.
Misc bug fixes and features, continued the refactor (singer-io#68) See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!49
You did it @DownstreamDataTeam! Thank you for signing the Singer Contribution License Agreement. |
Description of change
currency
field to loan_accountspayment_details
field to deposit_transactionsstatus
field to tasks streamgl_journal_entries
stream to fix missing record at large extractions (very big offset)endpoint_config
dict with class propertiesManual QA steps
Rollback steps