Continued refactor, added code scanning and added new fields #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull changes from Stitch See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!32
release/37 changes, squashed See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!37
…e/38' [ECDDC-575] Refactor Clients stream See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!40
…ream' # Conflicts: # tap_mambu/sync.py # tap_mambu/tap_mambu_refactor/main.py
…e/38' [ECDDC-555] Refactor centres stream See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!39
…ream' into 'release/38' [ECDDC-604] Added field "assigned_branch_key" to clients stream See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!42
… into 'release/38' [ECDDC-607] Changed readme file to correct tap_config.json into config.json See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!44
…elease/38' [ECDDC-601] Add code scanning with sonar See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!43
…_move-unit-tests_release-38
…/ECDDC-625_move-unit-tests_release-38
# Conflicts: # .gitlab-ci.yml
…se/38' [ECDDC-554] Refactor branches stream See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!45
[ECDDC-572] Added Snyk scanning See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!41
…ase/38' [ECDDC-625] Move unit tests (release 38) See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!47
|
Hi @DownstreamDataTeam, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
# Conflicts: # .gitlab-ci.yml # refactor_tests/tap_generators/test_generators.py # tap_mambu/sync.py # tap_mambu/tap_mambu_refactor/main.py
DownstreamDataTeam
changed the title
Misc bug fixes and features, continued the refactor (singer-io#68) See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!49
dmosorast
approved these changes
Mar 4, 2022
|
You did it @DownstreamDataTeam! Thank you for signing the Singer Contribution License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps