Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continued refactoring, added new fields, bugfixes and unit tests #74

Merged
merged 129 commits into from
Apr 8, 2022

Conversation

DownstreamDataTeam
Copy link
Contributor

Description of change

  • Refactored the following streams:
    • Credit Arrangements
    • Users
    • Activities
    • Audit Trail
  • Added Interest Accrual Breakdown stream
  • Added new fields to Tasks and Loan Transactions streams
  • Changed our pipeline/unit tests a bit (For Sonar and Snyk integrations)
  • Removed redundant requirements.txt
  • Implemented unit test to check that fields we use in processing/bookmark are set to automatic in catalog/schema

Manual QA steps

Risks

Rollback steps

  • revert this branch

Radu Marinoiu and others added 30 commits February 14, 2022 09:05
Pull changes from Stitch

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!32
release/37 changes, squashed

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!37
…e/38'

[ECDDC-575] Refactor Clients stream

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!40
…ream'

# Conflicts:
#   tap_mambu/sync.py
#   tap_mambu/tap_mambu_refactor/main.py
…e/38'

[ECDDC-555] Refactor centres stream

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!39
…ream' into 'release/38'

[ECDDC-604] Added field "assigned_branch_key" to clients stream

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!42
… into 'release/38'

[ECDDC-607] Changed readme file to correct tap_config.json into config.json

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!44
…elease/38'

[ECDDC-601] Add code scanning with sonar

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!43
Alexandru Rosca and others added 17 commits March 24, 2022 12:21
…se/40'

[ECDDC-649] Added task_link_key field to tasks stream

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!75
[ECDDC-652] Adjusted Snyk dev test

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!67
…ease/40'

[ECDDC-653] Finished implementing catalog automatic fields checker test

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!77
…b.com:mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu into feature/ECDDC-657_Refactor-audit-trail-stream
…nto 'release/40'

[ECDDC-667] Added missing fields to loan_transaction's 'affected_amounts' object

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!81
…ease/40'

[ECDDC-658] Refactor activities stream

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!79
…l-stream'

# Conflicts:
#   refactor_tests/tap_processors/test_processors.py
#   tap_mambu/sync.py
#   tap_mambu/tap_mambu_refactor/helpers/generator_processor_pairs.py
#   tap_mambu/tap_mambu_refactor/tap_generators/generator.py
@cmerrick
Copy link
Contributor

Hi @DownstreamDataTeam, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

…lease/40'

[ECDDC-657] Refactor audit trail stream

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!80
@DownstreamDataTeam DownstreamDataTeam marked this pull request as ready for review March 30, 2022 13:14
Version 2.4.2 and changelog (singer-io#73)

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!82
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question and a test change.

tap_mambu/schemas/loan_transactions.json Show resolved Hide resolved
tap_mambu/sync.py Show resolved Hide resolved
Radu Marinoiu added 2 commits April 1, 2022 11:04
…t' into 'release/40'

[ECDDC-674] Added old field back, so that the change is backwards compatible

See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!84
Copy link
Contributor

@dmosorast dmosorast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with the team directly that interest accrual breakdown works, and in lieu of data not currently coming through for our test account, that is acceptable to get the feature moving, so I'm good to merge and release this now. Will continue trying to get data for regression protection here.

@dmosorast dmosorast merged commit 2234d3c into singer-io:master Apr 8, 2022
@singer-bot
Copy link

You did it @DownstreamDataTeam!

Thank you for signing the Singer Contribution License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants