-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continued refactoring, added new fields, bugfixes and unit tests #74
Conversation
Pull changes from Stitch See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!32
release/37 changes, squashed See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!37
…e/38' [ECDDC-575] Refactor Clients stream See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!40
…ream' # Conflicts: # tap_mambu/sync.py # tap_mambu/tap_mambu_refactor/main.py
…e/38' [ECDDC-555] Refactor centres stream See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!39
…ream' into 'release/38' [ECDDC-604] Added field "assigned_branch_key" to clients stream See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!42
… into 'release/38' [ECDDC-607] Changed readme file to correct tap_config.json into config.json See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!44
…elease/38' [ECDDC-601] Add code scanning with sonar See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!43
…_move-unit-tests_release-38
…se/40' [ECDDC-649] Added task_link_key field to tasks stream See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!75
[ECDDC-652] Adjusted Snyk dev test See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!67
…ease/40' [ECDDC-653] Finished implementing catalog automatic fields checker test See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!77
…b.com:mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu into feature/ECDDC-657_Refactor-audit-trail-stream
…nto 'release/40' [ECDDC-667] Added missing fields to loan_transaction's 'affected_amounts' object See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!81
…ease/40' [ECDDC-658] Refactor activities stream See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!79
…l-stream' # Conflicts: # refactor_tests/tap_processors/test_processors.py # tap_mambu/sync.py # tap_mambu/tap_mambu_refactor/helpers/generator_processor_pairs.py # tap_mambu/tap_mambu_refactor/tap_generators/generator.py
Hi @DownstreamDataTeam, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
…lease/40' [ECDDC-657] Refactor audit trail stream See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!80
Version 2.4.2 and changelog (singer-io#73) See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!82
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question and a test change.
…t' into 'release/40' [ECDDC-674] Added old field back, so that the change is backwards compatible See merge request mambucom/product/ecosystem/mambu-marketplace/connectors/singer/tap-mambu!84
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with the team directly that interest accrual breakdown works, and in lieu of data not currently coming through for our test account, that is acceptable to get the feature moving, so I'm good to merge and release this now. Will continue trying to get data for regression protection here.
You did it @DownstreamDataTeam! Thank you for signing the Singer Contribution License Agreement. |
Description of change
Manual QA steps
Risks
Rollback steps