Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CR #73

Merged
merged 3 commits into from Apr 22, 2021
Merged

Remove CR #73

merged 3 commits into from Apr 22, 2021

Conversation

KAllan357
Copy link
Contributor

@KAllan357 KAllan357 commented Apr 16, 2021

Description of change

Each chunk gets converted to bytes, we find and remove and CR and CRLF's, and then they decode back to a string. replacements for CR and CRLF.

In an effort to change as little as possible, I avoided removing decode_unicode=True which would remove the requirement of converting the chunks to bytes. Also there might not be a need to do the bytes conversion.

Manual QA steps

Risks

Rollback steps

  • revert this branch

tap_marketo/sync.py Outdated Show resolved Hide resolved
tap_marketo/sync.py Outdated Show resolved Hide resolved
@KAllan357 KAllan357 changed the title Remove crlf Remove CR Apr 22, 2021
@KAllan357 KAllan357 merged commit c5a5859 into master Apr 22, 2021
@KAllan357 KAllan357 deleted the remove-crlf branch April 22, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants