TDL-14798: Add a proper error message for timezone issue by savan-chovatiya · Pull Request #35 · singer-io/tap-mixpanel

savan-chovatiya · 2021-09-03T13:39:28Z

Description of change

TDL-14798: TimeZones appear to break customer syncs

As per finalized approach, added error handling as part of this ticket, as we can not fetch timezone via API.

Manual QA steps

Verified that proper error message is raised in case of timezone-related API failure.

Risks

Rollback steps

revert this branch

* TDL-14794: Added new tep-tester test cases * TDL-14794: Updated CCI * TDL-14794: Fixed pagination bug * TDL-14794: Updated test path * TDL-14794: Removed unused imports * TDL-14794: Removed unused import * TDL-14794: Formated the code * TDL-14794: Removed page size * TDL-14794: Added backoff for 429 * Test: Put loggers * TDL-14794: Updated the error handling of tap * TDL-14794: Put latest start date * TDL-14794: Updated test cases with end_date * TDL-14794: Made replication_keys automatic * TDL-14794: Resolved review comments * TDL-14794: Updated start date * TDL-14794: Updated test cases to test more scenarios * TDL-14794: Added Unit tests and all_filed tests cases in pagination test * TDL-14794: Updated pytest to nose * TDL-14794: Updated parent class of 500 error Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>

* TDL-14795: Changed stream and sync file structure from dict base to class base * TDL-14795: Removed unused imports * TDL-14795: Updated replication key logic * TDL-14795: Converted code from CLRF to LF * TDL-14795: Optimized the code Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>

* TDL-14795: Changed stream and sync file structure from dict base to class base * TDL-14795: Removed unused imports * TDL-14795: Updated replication key logic * TDL-14795: Converted code from CLRF to LF * TDL-14795: Optimized the code * TDL-14795: Updated code to make compaitable with new tap code structure * TDL-14795: Removed res files Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>

* TDL-14794: Added new tep-tester test cases * TDL-14794: Updated CCI * TDL-14794: Fixed pagination bug * TDL-14794: Updated test path * TDL-14794: Removed unused imports * TDL-14794: Removed unused import * TDL-14794: Formated the code * TDL-14794: Removed page size * TDL-14794: Added backoff for 429 * Test: Put loggers * TDL-14794: Updated the error handling of tap * TDL-14794: Put latest start date * TDL-14794: Updated test cases with end_date * TDL-14794: Made replication_keys automatic * TDL-14794: Resolved review comments * TDL-14794: Updated start date * TDL-14794: Updated test cases to test more scenarios * TDL-14794: Added Unit tests and all_filed tests cases in pagination test * TDL-14794: Updated pytest to nose * TDL-14794: Updated parent class of 500 error * TDL-14794: Removed content length as Andy suggested in github Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>

karanpanchal-crest · 2021-09-24T10:07:20Z

+                error_code, {})).get(
+                    "message", "Unknown Error"))
+
+    # if response text contains something unusual errpr of to_date then provide helper message of timezone mismatch


@savan-chovatiya Resolve the spelling mistake in the comment for word 'error'

Resolved spell mistake.

karanpanchal-crest · 2021-09-24T10:09:48Z

+    if error_code == 400 and "to_date" in response.text:
+        error_message += " Please validate the timezone with the MixPanel UI under project settings."
+
+    message = "HTTP-error-code: {}, Error: {}".format(


@savan-chovatiya As per the latest best practices, please use f-strings instead of format

Updated formatted message with f-strings.

karanpanchal-crest · 2021-09-24T10:12:12Z

-
+# Mock response
+def get_mock_http_response(content, status_code):
+    contents = content


@savan-chovatiya No need of this variable. You can directly use 'content' variable at line 13

Removed contents variable and directly used content.

* TDL-14840: Updated transform to fix conversion * Tdl 14794 implement tap tester tests (#30) * TDL-14794: Added new tep-tester test cases * TDL-14794: Updated CCI * TDL-14794: Fixed pagination bug * TDL-14794: Updated test path * TDL-14794: Removed unused imports * TDL-14794: Removed unused import * TDL-14794: Formated the code * TDL-14794: Removed page size * TDL-14794: Added backoff for 429 * Test: Put loggers * TDL-14794: Updated the error handling of tap * TDL-14794: Put latest start date * TDL-14794: Updated test cases with end_date * TDL-14794: Made replication_keys automatic * TDL-14794: Resolved review comments * TDL-14794: Updated start date * TDL-14794: Updated test cases to test more scenarios * TDL-14794: Added Unit tests and all_filed tests cases in pagination test * TDL-14794: Updated pytest to nose * TDL-14794: Updated parent class of 500 error Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> * Tdl 14795 streams and sync should not be dict based (#32) * TDL-14795: Changed stream and sync file structure from dict base to class base * TDL-14795: Removed unused imports * TDL-14795: Updated replication key logic * TDL-14795: Converted code from CLRF to LF * TDL-14795: Optimized the code Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> * Tdl 14795 streams and sync should not be dict based (#33) * TDL-14795: Changed stream and sync file structure from dict base to class base * TDL-14795: Removed unused imports * TDL-14795: Updated replication key logic * TDL-14795: Converted code from CLRF to LF * TDL-14795: Optimized the code * TDL-14795: Updated code to make compaitable with new tap code structure * TDL-14795: Removed res files Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> * Tdl 14794 implement tap tester tests (#34) * TDL-14794: Added new tep-tester test cases * TDL-14794: Updated CCI * TDL-14794: Fixed pagination bug * TDL-14794: Updated test path * TDL-14794: Removed unused imports * TDL-14794: Removed unused import * TDL-14794: Formated the code * TDL-14794: Removed page size * TDL-14794: Added backoff for 429 * Test: Put loggers * TDL-14794: Updated the error handling of tap * TDL-14794: Put latest start date * TDL-14794: Updated test cases with end_date * TDL-14794: Made replication_keys automatic * TDL-14794: Resolved review comments * TDL-14794: Updated start date * TDL-14794: Updated test cases to test more scenarios * TDL-14794: Added Unit tests and all_filed tests cases in pagination test * TDL-14794: Updated pytest to nose * TDL-14794: Updated parent class of 500 error * TDL-14794: Removed content length as Andy suggested in github Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> * TDL-14840: Resolved merge conflicts * TDL-14840: Removed extra space * TDL-14840: Removed extra line * Added coverage report to artifact0 * Updated artifact sequence * Added code comment Co-authored-by: savan-chovatiya <savan.chovatiya@crestdatasys.com> Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com> Co-authored-by: prijendev <88327452+prijendev@users.noreply.github.com>

* Tdl 14794 implement tap tester tests (#30) * TDL-14794: Added new tep-tester test cases * TDL-14794: Updated CCI * TDL-14794: Fixed pagination bug * TDL-14794: Updated test path * TDL-14794: Removed unused imports * TDL-14794: Removed unused import * TDL-14794: Formated the code * TDL-14794: Removed page size * TDL-14794: Added backoff for 429 * Test: Put loggers * TDL-14794: Updated the error handling of tap * TDL-14794: Put latest start date * TDL-14794: Updated test cases with end_date * TDL-14794: Made replication_keys automatic * TDL-14794: Resolved review comments * TDL-14794: Updated start date * TDL-14794: Updated test cases to test more scenarios * TDL-14794: Added Unit tests and all_filed tests cases in pagination test * TDL-14794: Updated pytest to nose * TDL-14794: Updated parent class of 500 error Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> * Tdl 14795 streams and sync should not be dict based (#32) * TDL-14795: Changed stream and sync file structure from dict base to class base * TDL-14795: Removed unused imports * TDL-14795: Updated replication key logic * TDL-14795: Converted code from CLRF to LF * TDL-14795: Optimized the code Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> * Tdl 14795 streams and sync should not be dict based (#33) * TDL-14795: Changed stream and sync file structure from dict base to class base * TDL-14795: Removed unused imports * TDL-14795: Updated replication key logic * TDL-14795: Converted code from CLRF to LF * TDL-14795: Optimized the code * TDL-14795: Updated code to make compaitable with new tap code structure * TDL-14795: Removed res files Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> * Tdl 14794 implement tap tester tests (#34) * TDL-14794: Added new tep-tester test cases * TDL-14794: Updated CCI * TDL-14794: Fixed pagination bug * TDL-14794: Updated test path * TDL-14794: Removed unused imports * TDL-14794: Removed unused import * TDL-14794: Formated the code * TDL-14794: Removed page size * TDL-14794: Added backoff for 429 * Test: Put loggers * TDL-14794: Updated the error handling of tap * TDL-14794: Put latest start date * TDL-14794: Updated test cases with end_date * TDL-14794: Made replication_keys automatic * TDL-14794: Resolved review comments * TDL-14794: Updated start date * TDL-14794: Updated test cases to test more scenarios * TDL-14794: Added Unit tests and all_filed tests cases in pagination test * TDL-14794: Updated pytest to nose * TDL-14794: Updated parent class of 500 error * TDL-14794: Removed content length as Andy suggested in github Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> * TDL-6141: Switched multipleOf with singer.decimal * TDL-6141 removed the whitespaces * TDL-6141 removed the multipleOf from schema.py * TDL-6141 removed a whitespace * TDL-6141: Resolved merge conflicts * Added coverage report to artifact * Updated circleci config.yml Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local> Co-authored-by: savan-chovatiya <savan.chovatiya@crestdatasys.com> Co-authored-by: namrata270998 <namrata.brahmbhatt@crestdatasys.com> Co-authored-by: namrata270998 <75604662+namrata270998@users.noreply.github.com> Co-authored-by: prijendev <88327452+prijendev@users.noreply.github.com> Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com>

…e-issue-in-api

prijendev · 2022-09-27T07:48:48Z

The code change of this PR is already merged into the main branch. Hence, closing this PR.

dbshah1212 and others added 5 commits September 2, 2021 11:22

TSL-14798: Add a proper error message for timezone issue

7d95dc4

savan-chovatiya requested review from dbshah1212 and karanpanchal-crest September 13, 2021 09:46

karanpanchal-crest changed the base branch from crest-develop to master September 24, 2021 10:04

karanpanchal-crest changed the base branch from master to crest-develop September 24, 2021 10:04

karanpanchal-crest reviewed Sep 24, 2021

View reviewed changes

savan-chovatiya changed the base branch from crest-develop to master September 27, 2021 07:28

savan-chovatiya changed the base branch from master to crest-develop September 27, 2021 07:30

Merge branch 'master' into TDL-14798-fix-timezone-issue-in-api

a432a87

dbshah1212 changed the base branch from crest-develop to master September 27, 2021 08:45

dbshah1212 and others added 8 commits September 27, 2021 14:16

TDL-14798: Removed extra line

7618e46

TDL-14798: Resolved merge conflicts

d68b27c

Resolve review comments

1a59e30

TDL-14798: Updated error message

7455ee7

TDL-14798: Updated error message for 402

70cae72

TDL-14798: Updated singer-python version

b80319d

TDL-14798: added unit test for messages retrived from API response

799d232

TDL-14798: Updated unit test

ca25bb3

karanpanchal-crest approved these changes Sep 29, 2021

View reviewed changes

savan-chovatiya requested review from luandy64 and zachharris1 September 29, 2021 10:21

dbshah1212 requested review from KrisPersonal and cosimon September 30, 2021 08:39

removed f-string

60f5a33

savan-chovatiya and others added 3 commits October 19, 2021 12:17

Resolved merge conflicts

add719d

Merge branch 'master' into TDL-14798-fix-timezone-issue-in-api

96cac7e

Added coverage report to artifact

178ca69

KrisPersonal approved these changes Oct 21, 2021

View reviewed changes

Updated circleci config.yml

ae4b325

KrisPersonal approved these changes Oct 26, 2021

View reviewed changes

dbshah1212 and others added 3 commits October 27, 2021 11:50

Merge branch 'TDL-14784-mixpanel-all-code' into TDL-14798-fix-timezon…

be46d80

…e-issue-in-api

dbshah1212 mentioned this pull request Oct 27, 2021

Tdl 14784 mixpanel all code #48

Merged

prijendev closed this Sep 27, 2022

Navigation Menu

Uh oh!

TDL-14798: Add a proper error message for timezone issue - #35

TDL-14798: Add a proper error message for timezone issue#35
savan-chovatiya wants to merge 22 commits into
masterfrom
TDL-14798-fix-timezone-issue-in-api

savan-chovatiya commented Sep 3, 2021 •

edited

Loading

Uh oh!

karanpanchal-crest Sep 24, 2021

Uh oh!

savan-chovatiya Sep 27, 2021

Uh oh!

karanpanchal-crest Sep 24, 2021

Uh oh!

savan-chovatiya Sep 27, 2021

Uh oh!

karanpanchal-crest Sep 24, 2021

Uh oh!

savan-chovatiya Sep 27, 2021

Uh oh!

prijendev commented Sep 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

savan-chovatiya commented Sep 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of change

Manual QA steps

Risks

Rollback steps

Uh oh!

karanpanchal-crest Sep 24, 2021

Choose a reason for hiding this comment

Uh oh!

savan-chovatiya Sep 27, 2021

Choose a reason for hiding this comment

Uh oh!

karanpanchal-crest Sep 24, 2021

Choose a reason for hiding this comment

Uh oh!

savan-chovatiya Sep 27, 2021

Choose a reason for hiding this comment

Uh oh!

karanpanchal-crest Sep 24, 2021

Choose a reason for hiding this comment

Uh oh!

savan-chovatiya Sep 27, 2021

Choose a reason for hiding this comment

Uh oh!

prijendev commented Sep 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

savan-chovatiya commented Sep 3, 2021 •

edited

Loading