Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL-6141: Switch from using multipleOf to singer.decimal #38

Closed

Conversation

savan-chovatiya
Copy link
Contributor

@savan-chovatiya savan-chovatiya commented Sep 6, 2021

Description of change

TDL-6141: Switch from using multipleOf to singer.decimal

  • Changed from using type number and multipleOf 1e-20 to type string and format singer.decimal in funnels and revenue streams

Manual QA steps

Risks

Rollback steps

  • revert this branch

dbshah1212 and others added 5 commits September 2, 2021 11:22
* TDL-14794: Added new tep-tester test cases

* TDL-14794: Updated CCI

* TDL-14794: Fixed pagination bug

* TDL-14794: Updated test path

* TDL-14794: Removed unused imports

* TDL-14794: Removed unused import

* TDL-14794: Formated the code

* TDL-14794: Removed page size

* TDL-14794: Added backoff for 429

* Test: Put loggers

* TDL-14794: Updated the error handling of tap

* TDL-14794: Put latest start date

* TDL-14794: Updated test cases with end_date

* TDL-14794: Made replication_keys automatic

* TDL-14794: Resolved review comments

* TDL-14794: Updated start date

* TDL-14794: Updated test cases to test more scenarios

* TDL-14794: Added Unit tests and all_filed tests cases in pagination test

* TDL-14794: Updated pytest to nose

* TDL-14794: Updated parent class of 500 error

Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>
* TDL-14795: Changed stream and sync file structure from dict base to class base

* TDL-14795: Removed unused imports

* TDL-14795: Updated replication key logic

* TDL-14795: Converted code from CLRF to LF

* TDL-14795: Optimized the code

Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>
* TDL-14795: Changed stream and sync file structure from dict base to class base

* TDL-14795: Removed unused imports

* TDL-14795: Updated replication key logic

* TDL-14795: Converted code from CLRF to LF

* TDL-14795: Optimized the code

* TDL-14795: Updated code to make compaitable with new tap code structure

* TDL-14795: Removed res files

Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>
* TDL-14794: Added new tep-tester test cases

* TDL-14794: Updated CCI

* TDL-14794: Fixed pagination bug

* TDL-14794: Updated test path

* TDL-14794: Removed unused imports

* TDL-14794: Removed unused import

* TDL-14794: Formated the code

* TDL-14794: Removed page size

* TDL-14794: Added backoff for 429

* Test: Put loggers

* TDL-14794: Updated the error handling of tap

* TDL-14794: Put latest start date

* TDL-14794: Updated test cases with end_date

* TDL-14794: Made replication_keys automatic

* TDL-14794: Resolved review comments

* TDL-14794: Updated start date

* TDL-14794: Updated test cases to test more scenarios

* TDL-14794: Added Unit tests and all_filed tests cases in pagination test

* TDL-14794: Updated pytest to nose

* TDL-14794: Updated parent class of 500 error

* TDL-14794: Removed content length as Andy suggested in github

Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>
@namrata270998 namrata270998 requested review from ajmers, dbshah1212 and karanpanchal-crest and removed request for ajmers September 13, 2021 09:50
"format": "date"
},
"datetime": {
"type": ["null", "string"],
"type": [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@namrata270998 Re-structuring the "type" array is not expected as part of this PR. Can you please revert this change?

@dbshah1212 dbshah1212 changed the base branch from crest-develop to master September 27, 2021 07:21
dbshah1212 and others added 2 commits October 27, 2021 11:50
* TDL-14840: Updated transform to fix conversion

* Tdl 14794 implement tap tester tests (#30)

* TDL-14794: Added new tep-tester test cases

* TDL-14794: Updated CCI

* TDL-14794: Fixed pagination bug

* TDL-14794: Updated test path

* TDL-14794: Removed unused imports

* TDL-14794: Removed unused import

* TDL-14794: Formated the code

* TDL-14794: Removed page size

* TDL-14794: Added backoff for 429

* Test: Put loggers

* TDL-14794: Updated the error handling of tap

* TDL-14794: Put latest start date

* TDL-14794: Updated test cases with end_date

* TDL-14794: Made replication_keys automatic

* TDL-14794: Resolved review comments

* TDL-14794: Updated start date

* TDL-14794: Updated test cases to test more scenarios

* TDL-14794: Added Unit tests and all_filed tests cases in pagination test

* TDL-14794: Updated pytest to nose

* TDL-14794: Updated parent class of 500 error

Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>

* Tdl 14795 streams and sync should not be dict based (#32)

* TDL-14795: Changed stream and sync file structure from dict base to class base

* TDL-14795: Removed unused imports

* TDL-14795: Updated replication key logic

* TDL-14795: Converted code from CLRF to LF

* TDL-14795: Optimized the code

Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>

* Tdl 14795 streams and sync should not be dict based (#33)

* TDL-14795: Changed stream and sync file structure from dict base to class base

* TDL-14795: Removed unused imports

* TDL-14795: Updated replication key logic

* TDL-14795: Converted code from CLRF to LF

* TDL-14795: Optimized the code

* TDL-14795: Updated code to make compaitable with new tap code structure

* TDL-14795: Removed res files

Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>

* Tdl 14794 implement tap tester tests (#34)

* TDL-14794: Added new tep-tester test cases

* TDL-14794: Updated CCI

* TDL-14794: Fixed pagination bug

* TDL-14794: Updated test path

* TDL-14794: Removed unused imports

* TDL-14794: Removed unused import

* TDL-14794: Formated the code

* TDL-14794: Removed page size

* TDL-14794: Added backoff for 429

* Test: Put loggers

* TDL-14794: Updated the error handling of tap

* TDL-14794: Put latest start date

* TDL-14794: Updated test cases with end_date

* TDL-14794: Made replication_keys automatic

* TDL-14794: Resolved review comments

* TDL-14794: Updated start date

* TDL-14794: Updated test cases to test more scenarios

* TDL-14794: Added Unit tests and all_filed tests cases in pagination test

* TDL-14794: Updated pytest to nose

* TDL-14794: Updated parent class of 500 error

* TDL-14794: Removed content length as Andy suggested in github

Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>

* TDL-14840: Resolved merge conflicts

* TDL-14840: Removed extra space

* TDL-14840: Removed extra line

* Added coverage report to artifact0

* Updated artifact sequence

* Added code comment

Co-authored-by: savan-chovatiya <savan.chovatiya@crestdatasys.com>
Co-authored-by: dbshah1212 <root@ubuntu16.cdsys.local>
Co-authored-by: prijendev <prijen.khokhani@crestdatasys.com>
Co-authored-by: prijendev <88327452+prijendev@users.noreply.github.com>
@prijendev
Copy link
Contributor

The code change of this PR is already merged in the main branch. Hence, closing this PR.

@prijendev prijendev closed this Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants