Add request timeout property #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RushiT0122
approved these changes
Sep 6, 2023
* initial test case * test case to verify the backoff logic * test cases to check exceptions within the code flow * add unit test for sync endpoint * update function name from `sync` to `sync_endpoint` to avoid the name conflicts * Add pylint and unit test step in circleci * update setup.py with the required packages * make pylint happy * Review changes * review changes * initial test case * test case to verify the backoff logic * test cases to check exceptions within the code flow * add unit test for sync endpoint * update function name from `sync` to `sync_endpoint` to avoid the name conflicts * Add pylint and unit test step in circleci * update setup.py with the required packages * make pylint happy * Review changes * review changes * break logger statement * make pylint happy
shantanu73
approved these changes
Sep 6, 2023
Contributor
shantanu73
left a comment
shantanu73
left a comment
There was a problem hiding this comment.
Approving Changelog & setup.py changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Add request timeout property for tap-outreach
Manual QA steps
Risks
Rollback steps