Skip to content

* fix visitor history bookmarking issue #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

RushiT0122
Copy link
Contributor

Description of change

Due to date windowing logic, visitor_history records older than bookmark were getting synced.

Manual QA steps

  • Verify bookmark test is passing on the local dev env.

Risks

Rollback steps

  • revert this branch

@RushiT0122 RushiT0122 force-pushed the TDL-22519-fix-visitor-history-bookmarking branch from ca29292 to 4f02315 Compare March 27, 2023 15:35
@RushiT0122 RushiT0122 requested a review from zachharris1 March 27, 2023 15:40
@RushiT0122 RushiT0122 merged commit 44f2a7f into master Mar 28, 2023
@RushiT0122 RushiT0122 mentioned this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants