All primary key related changes #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachharris1
approved these changes
Mar 27, 2023
* TDL-15317: Updated primary key for feature-events * Moved integration test * TDL-15317: Updated integration test * updated readme file * Resolved internal PR review comments * Resolved review comments * run bookmark test with hour and day range Co-authored-by: harshpatel4_crest <harsh.patel4@crestdatasys.com> Co-authored-by: Harsh <80324346+harshpatel4crest@users.noreply.github.com>
* updated PK for track_events stream * updated the comment according to the comments * updated readme file * added unittest * updated unittests, updated config.yml file * run bookmark test for day and hour range * Disabling integration test for merge and enable it in pendo-pk-changes Co-authored-by: harshpatel4_crest <harsh.patel4@crestdatasys.com> Co-authored-by: Harsh <80324346+harshpatel4crest@users.noreply.github.com>
* TDL-15338: Updated primary keys for events * TDL-15338: Updated integration test * updated readme file * Resolved internal PR review comments * Resolved review comments * run bookmark test with hour and day range Co-authored-by: harshpatel4_crest <harsh.patel4@crestdatasys.com> Co-authored-by: Harsh <80324346+harshpatel4crest@users.noreply.github.com>
* updated PK for guide events * added unittests * updated readme file Co-authored-by: harshpatel4_crest <harsh.patel4@crestdatasys.com>
* updated PK for poll events * updated readme file Co-authored-by: harshpatel4_crest <harsh.patel4@crestdatasys.com> Co-authored-by: Harsh <80324346+harshpatel4crest@users.noreply.github.com>
* TDL-15149: Updated primary key for page-events * Added new line in end of file * Updated discovery test * TDL-15149: Updated integration test * updated readme file * Resolved PR review comments * Resolved review comments * added code to add hash field in the record for page events * resolve pylint error * updated readme file * run bookmark with day and hour range * created function to calculate hash in the unittests * updated unittest of generating hash Co-authored-by: harshpatel4_crest <harsh.patel4@crestdatasys.com>
RushiT0122
force-pushed
the
pendo-pk-changes
branch
from
d7dc60f to
a9c082d
Compare
RushiT0122
force-pushed
the
pendo-pk-changes
branch
from
2168c23 to
a60e9f4
Compare
RushiT0122
force-pushed
the
pendo-pk-changes
branch
from
192a745 to
e766604
Compare
sgandhi1311
reviewed
Mar 29, 2023
sgandhi1311
reviewed
Mar 29, 2023
sgandhi1311
reviewed
Mar 29, 2023
sgandhi1311
reviewed
Mar 29, 2023
sgandhi1311
reviewed
Mar 29, 2023
Co-authored-by: Sourabh Gandhi <105213416+sgandhi1311@users.noreply.github.com>
Co-authored-by: Sourabh Gandhi <105213416+sgandhi1311@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps