Skip to content

Handle new structure for users rows #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

dmosorast
Copy link
Contributor

Description of change

This PR is a reaction to an undocumented change that went out with this Changelog Entry to the Users API.

It appears that there was a cleanliness change to change the structure from a single-element list to a JSON object like the other streams.

Since this was an undocumented and (likely) unintentional change, this PR accepts both formats in case of a rollback to continue functionality.

Manual QA steps

  • Ran through this, got the failure, made this change, and the extraction succeeded

Risks

  • Low, it is currently 100% broken on this line, and the fallback should maintain compatibility in the event of a reversion on Pipedrive's end.

Rollback steps

  • revert this branch, bump patch version, re-release

@dmosorast dmosorast merged commit ce652ea into master Aug 9, 2022
@dmosorast dmosorast deleted the fix/users-response-structure-change branch August 9, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants