Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDL 20379 : [tap-pipedrive] Anomalous failed jobs #120

Merged
merged 5 commits into from
Sep 2, 2022

Conversation

shantanu73
Copy link
Contributor

@shantanu73 shantanu73 commented Sep 1, 2022

Description of change

JIRA : TDL-20379
There are Anomalous failing jobs related to tap-pipedrive here.
The changes here include resolution for below issues observed for some customers:-

  1. "Nonetype" issues
  2. Transformation issues

And, Integration test changes.

Manual QA steps

Risks

Rollback steps

  • revert this branch

1) Added code to skip fetching deal_ids when stream request response doesn't have any data in it.
2) Added code to check if payload is None in validate_response method.
1) Fixed transformation issue.
1) Modified all fields integration test.
1) Added string as last type of a property for dynamic field schema.
1) fixed the order for fetching payload data.
@shantanu73 shantanu73 merged commit 8cbf233 into master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants