Skip to content

Retry null requests for DealsFlow stream #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 9, 2023

Conversation

leslievandemark
Copy link
Contributor

Description of change

Manual QA steps

  • applied the change as a pr-alpha to client in TDL-22119 and resolved the error they were receiving.

Risks

  • Adding a new header could possibly change things for other streams, but the tap expects data to be returned as json, so it would likely be for the better.

Rollback steps

  • revert this branch

@leslievandemark leslievandemark changed the title Tdl 22119/retry reqs with null bodies Retry null requests for DealsFlow stream Mar 8, 2023
@leslievandemark leslievandemark merged commit a0dd976 into master Mar 9, 2023
@GeorgeTouros
Copy link

GeorgeTouros commented Mar 31, 2023

This change seems to have broken our data pipeline using Stitch. Since March 12, we have been experiencing infinite retries on the object, returning NULL values and status 200, causing the pipeline to continue running in perpetuity. See the latency logs attached.

image

The max number of retries seems to also not work here, because every few times we get a response with 1 row, thus re-initiating the cycle all along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants