Dependabot issue fix#140
Merged
Merged
Conversation
prijendev
commented
Jan 21, 2025
|
|
||
| def test_run(self): | ||
| # page size for "deals" | ||
| # page size for "pipelines" |
Contributor
Author
There was a problem hiding this comment.
We do not have enough records for deals stream to test the pagination. So, replaced it with pipeline stream.
rdeshmukh15
requested changes
Jan 21, 2025
Comment on lines
+117
to
+118
| if stream == "users": | ||
| self.assertGreaterEqual(record_count_sync_1, record_count_sync_2) |
Member
There was a problem hiding this comment.
How many records we have for users?
Contributor
Author
There was a problem hiding this comment.
We have only 1 user record. It is the current pipedrive user.
rdeshmukh15
reviewed
Jan 21, 2025
rdeshmukh15
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code