Skip to content

SAC-27349: Upgrade api version to v2 - #144

Merged
cosimon merged 9 commits into
masterfrom
SAC-27349-upgrade-api-version-to-v2
Jul 9, 2025
Merged

cosimon merged 9 commits into
masterfrom
SAC-27349-upgrade-api-version-to-v2

Conversation

@prijendev

@prijendev prijendev commented May 20, 2025 •

Copy link
Copy Markdown
Contributor

Description of change

  • Upgrade api version to v2 for the below endpoints
  • Replace /recent endpoints with respective /list endpoints to sync the historical data
  • Update replication method to INCREMENTAL for the below streams
    • activity_types
    • filters
    • notes
    • pipelines
    • stages

Manual QA steps

  • Run the discover mode with the master and current branches and verify the generated catalog.
  • Run the sync mode with the master and current branches and verify the number of records.
  • Run the sync with the state and verify the bookmarking.
  • Verify the number of records synced

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

Comment thread CHANGELOG.md Outdated
Comment thread setup.py Outdated
Comment thread setup.py Outdated
Comment thread tap_pipedrive/schemas/stages.json Outdated
@prijendev
prijendev requested a review from rdeshmukh15 May 26, 2025 10:41
@cosimon
cosimon merged commit 29e7afd into master Jul 9, 2025
@skuttleman skuttleman mentioned this pull request Jul 14, 2025
1 task
@joshuataylor

Copy link
Copy Markdown

This is a great change, but should have been documented that certain fields may have changed, due to Pipedrive API.

e.g is_deleted now has to be checked for false OR NULL, as they API returns both...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants