-
Notifications
You must be signed in to change notification settings - Fork 36
TDL-12581: Increase tap tester coverage #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| endpoint = 'pipelines' | ||
| schema = 'pipelines' | ||
| key_properties = ['id', ] | ||
| state_field = 'update_time' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So tables like these had a state_field but were operating full_table anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @KAllan357, Please find the doc link which shows all the streams having similar behavior in the tap https://talend365-my.sharepoint.com/:w:/g/personal/kpanchal_talend_com/EV4SU6EM5khDmDobC-hIXc4Bmv6cx-mx7NCOVLeCkS1HXg?e=B4Pohm
Description of change
TDL-12581: Added integration test suite for:
Some of the highlighted changes as part of this PR:
Recent ( All are INCREMENTAL as sine_timestamp is mandatory param )
PipedriveIterStream
dealflow - It calls update_endpoint which calls get_deal_ids in which we run the loop to take data after updated_field so INCREMENTALOthers ( Full_Table )
Manual QA steps
Risks
Rollback steps