Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SSL #80

merged 2 commits into from Feb 28, 2020

Enable SSL #80

merged 2 commits into from Feb 28, 2020


Copy link

Description of change

ssl is a config property for tap-postgres, but it wasn't actually being used when opening a connection to the db.

This PR adds the sslmode param when opening a connection if the config prop ssl = true

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
  • Added ssl: true to tap-tester and verified that it passed locally


connections that have ssl turned on but, for some reason, have it disabled on their db will start failing.

Rollback steps

  • revert this branch

@nick-mccoy nick-mccoy changed the title Turn on ssl Enable SSL Feb 27, 2020
@nick-mccoy nick-mccoy merged commit ab6d73f into master Feb 28, 2020
@nick-mccoy nick-mccoy deleted the turn-on-ssl branch February 28, 2020 21:00
@nick-mccoy nick-mccoy mentioned this pull request Mar 5, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants